Simplify sprintf translation for percentage widths
#68587
Conversation
im3dabasia
requested review from
ellatrix,
ajitbohra and
fabiankaegy
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hey @t-hamano , When you have a moment, could you please review my PR? I'd appreciate your feedback. I’m not sure why the linting checks for JavaScript are failing. The changes I made didn’t raise any linting errors during development. |
Mamaduka
added
[Type] Enhancement
|
@im3dabasia, rebasing should fix the failing Static Analysis check. |
im3dabasia
force-pushed
the
fix/simplify-translation-strings
branch
from
fbe92d3 to
9a9fdf7
Compare
t-hamano
added
the
props-bot
github-actions
bot
removed
the
props-bot
…ss#68587) Co-authored-by: im3dabasia <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: Mamaduka <[email protected]>
Related comment: #68270 (comment)
Related issues: #52787 , #66323 (review)
What?
This PR refines the code quality by simplifying the translation of percentage widths.
Why?
The previous implementation used
__( '%1$d%%' )due to an ESLint error being flagged when using the simpler__( '%d%%' ). Now that thesprintfregex has been updated, this simplification is possible without causing issues. The change ensures consistency across the codebase and improves readability.How?
Replaced
__( '%1$d%%' )with__( '%d%%' )for percentage translations.